Docs: inline function Dockerfile, remove kfn download link - #4734
Open
aravindtga wants to merge 1 commit into
Open
Docs: inline function Dockerfile, remove kfn download link#4734aravindtga wants to merge 1 commit into
aravindtga wants to merge 1 commit into
Conversation
Signed-off-by: Aravindhan Ayyanathan <aravindhan.a@est.tech>
✅ Deploy Preview for kptdocs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
aravindtga
marked this pull request as ready for review
September 4, 2026 17:09
aravindtga
requested review from
efiacor,
kispaljr,
liamfallon and
mozesl-nokia
as code owners
September 4, 2026 17:09
|
|
||
| The "get-started" package provides the `Dockerfile` that you can download using: | ||
| ```shell | ||
| wget https://raw.githubusercontent.com/kptdev/krm-functions-sdk/main/go/kfn/commands/embed/Dockerfile |
Contributor
There was a problem hiding this comment.
Should we even remove this file?
Contributor
Author
There was a problem hiding this comment.
Yes. The kfn tool is being removed from the project (issue #4731). That removal deletes go/kfn/commands/embed/Dockerfile, so the wget link this PR removes would otherwise become a dead link.
CsatariGergely
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Dockerfilecontents into the "Build the KRM function as a Docker image" section of the developing-functions book chapter, replacing thewgetdownload ofhttps://raw.githubusercontent.com/kptdev/krm-functions-sdk/main/go/kfn/commands/embed/Dockerfile.kfnis being removed from the project. That removal deletesgo/kfn/commands/embed/Dockerfileinkrm-functions-sdk, which would turn thewgetlink in this doc into a dead link.dockerfilecode block, removing the dependency on the SDK repo's internal layout.Related Issue(s)
Type of Change
Checklist
AI Disclosure
If so, please describe how:
- Kiro to analyse the
kfnremoval impact and to draft the documentation change.